fix: melting_temperature crashes with n_iterations > 1#218
Merged
srmnitc merged 1 commit intoICAMS:mainfrom Feb 27, 2026
Merged
fix: melting_temperature crashes with n_iterations > 1#218srmnitc merged 1 commit intoICAMS:mainfrom
srmnitc merged 1 commit intoICAMS:mainfrom
Conversation
…n_jobs When n_iterations > 1, integrate_reversible_scaling was called inside the for loop before all ts.forward_N.dat files existed, causing FileNotFoundError. Fixed by moving the call outside the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: move integrate_reversible_scaling outside loop in MeltingTemp.run_jobs
When n_iterations > 1, integrate_reversible_scaling was called inside
the for loop before all ts.forward_N.dat files existed, causing
FileNotFoundError. Fixed by moving the call outside the loop.